[dotnet-trace] Remove preview banner from collect-linux - #5970
Merged
mdh1418 merged 1 commit intoAug 24, 2026
Conversation
mdh1418
requested review from
hoyosjs and
noahfalk
and
a lite review from Copilot
August 20, 2026 18:21
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the “preview feature” banner that was printed when running dotnet-trace collect-linux, and updates functional tests to reflect the new console output.
Changes:
- Removed the preview banner
Console.WriteLine(...)block fromCollectLinux. - Updated
CollectLinuxCommandFunctionalTestsexpected output helpers to no longer include the preview banner lines.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Tools/dotnet-trace/CommandLine/Commands/CollectLinuxCommand.cs | Removes the preview banner printed at the start of collect-linux. |
| src/tests/dotnet-trace/CollectLinuxCommandFunctionalTests.cs | Updates expected output and helper methods to match the new (banner-free) output. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
hoyosjs
approved these changes
Aug 21, 2026
noahfalk
approved these changes
Aug 21, 2026
Member
|
Is there a corresponding PR to change the docs? |
Member
Author
|
Yes, just put it up here dotnet/docs#55628 |
max-charlamb
approved these changes
Aug 24, 2026
Member
Author
|
/ba-g Build failure is from the test failing, and the test is a known issue. |
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.